Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue#2004 : moved verifyMisbehviour function from update.go to misbehviour_handle.go #2376

Merged

Conversation

Daniyal98
Copy link
Contributor

@Daniyal98 Daniyal98 commented Sep 25, 2022

Description

closes: #2004


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@Daniyal98 Daniyal98 changed the title moved verifyMisbehviour function from update.go to misbehviour_handle.go issue#2004 : moved verifyMisbehviour function from update.go to misbehviour_handle.go Sep 25, 2022
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, @Daniyal98!

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #2376 (6a9a459) into main (3c21b5e) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2376   +/-   ##
=======================================
  Coverage   78.59%   78.59%           
=======================================
  Files         178      178           
  Lines       12322    12322           
=======================================
  Hits         9684     9684           
  Misses       2206     2206           
  Partials      432      432           
Impacted Files Coverage Δ
modules/light-clients/06-solomachine/update.go 92.50% <ø> (-0.91%) ⬇️
...ight-clients/06-solomachine/misbehaviour_handle.go 85.00% <100.00%> (+5.68%) ⬆️

Copy link
Contributor

@colin-axner colin-axner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Daniyal98!

Copy link
Member

@damiannolan damiannolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 🙏

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@chatton
Copy link
Contributor

chatton commented Sep 29, 2022

To fix the goimports errors you should be able to run make goimports-all

@Daniyal98
Copy link
Contributor Author

To fix the goimports errors you should be able to run make goimports-all

Yes, I believe its fixed now. Thank you!

@mergify mergify bot merged commit 7dcfc2c into cosmos:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move verifyMisbehaviour to misbehaviour_handle.go for 06-solomachine
7 participants